Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: avoid flaps with Koala.configure #665

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ylecuyer
Copy link
Collaborator

Before: we run Koala.reset_config in a before(:each) to avoid mutation on the global Koala.configuration object.

But there are some specs (for example ./spec/cases/test_users_spec.rb:285) which have their own before(:each) making calls to the graph api (before the reset) and in some cases it conflicts with the current state of the Koala.configuration for example after a test setting a bad configuration on purpose

Proposed fix is to reset the configuration in an after(:each) instead

…er before each have precedence)

bundle exec rspec --seed 12569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant